Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AWS SDK v2 #400

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Use AWS SDK v2 #400

merged 2 commits into from
Nov 25, 2024

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Nov 22, 2024 •
edited
Loading

What this PR does / why we need it:
Use AWS SDK v2 for the aws-route53 provider. The old SDK has entered maintenance mode and will not be supported after 7/31/2025.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
The gosec version has been updated indirectly and reported new issues in unrelated code with int types used for TTL at various places. The TTL types have been made more consistent, using int64 internally.

Release note:

Use AWS SDK v2 for the `aws-route53` provider

@MartinWeindel MartinWeindel requested a review from a team as a code owner November 22, 2024 15:14
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 22, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 22, 2024
marc1404
marc1404 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Well done! :)

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Nov 25, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 25, 2024
@MartinWeindel MartinWeindel merged commit 38e12f7 into master Nov 25, 2024
9 checks passed
@MartinWeindel MartinWeindel deleted the enh/use-aws-sdk-v2 branch November 25, 2024 12:54
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc1404 marc1404 marc1404 approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MartinWeindel @marc1404 @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot